Add some useful scalac options and fix stuff #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
[warn] -- [E165] Type Warning: /Users/tle/git/lichess/lila-search/modules/elastic/src/main/scala/game.scala:107:18
[warn] 107 | case s: String => termQuery(name, s.toLowerCase)
[warn] | ^^^^^^
[warn] | pattern selector should be an instance of Matchable,
[warn] | but it has unmatchable type query.A instead
[warn] |---------------------------------------------------------------------------
[warn] | Explanation (enabled by `-explain`)
[warn] |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
[warn] | A value of type query.A cannot be the selector of a match expression
[warn] | since it is not constrained to be `Matchable`. Matching on unconstrained
[warn] | values is disallowed since it can uncover implementation details that
[warn] | were intended to be hidden and thereby can violate paramtetricity laws
[warn] | for reasoning about programs.
[warn] |
[warn] | The restriction can be overridden by appending `.asMatchable` to
[warn] | the selector value. `asMatchable` needs to be imported from
[warn] | scala.compiletime. Example:
[warn] |
[warn] | import compiletime.asMatchable
[warn] | def f[X](x: X) = x.asMatchable match { ... }
[warn] ---------------------------------------------------------------------------
[warn] one warning found
```
lenguyenthanh
force-pushed
the
scalac
branch
from
f1babd6
to
3a8f8d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.