Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fishnet can't move in certain positions #12751

Closed
ornicar opened this issue Apr 28, 2023 · 3 comments
Closed

fishnet can't move in certain positions #12751

ornicar opened this issue Apr 28, 2023 · 3 comments
Labels
bug

Comments

@ornicar
Copy link
Collaborator

ornicar commented Apr 28, 2023

such as: https://lichess.org/editor/r2r3k/p2p4/8/8/8/8/P6P/R3K2R_w_KQq_-_0_1?color=white

I suspect black having queenside castle rights and two rooks on the "queenside" of the king results in weirdness.
@kraktus kraktus added the bug label Apr 29, 2023
@schlawg
Copy link
Collaborator

schlawg commented Apr 29, 2023

Wouldn't this be an issue for https://github.com/fairy-stockfish/Fairy-Stockfish? The INVALID_CASTLING_RIGHTS string comes from apiutil.h in that submodule

niklasf added a commit to lichess-org/fishnet that referenced this issue May 1, 2023
@niklasf
update shakmaty for relaxed castling right validation (lichess-org/li…
9a634bb 
…la#12751)
niklasf added a commit to lichess-org/fishnet that referenced this issue May 1, 2023
@niklasf
silently drop invalid castling and ep flags (lichess-org/lila#12751)
c1f485d
@niklasf
Copy link
Member

niklasf commented May 1, 2023

it's https://docs.rs/shakmaty/0.25.0/shakmaty/struct.PositionErrorKinds.html#associatedconstant.INVALID_CASTLING_RIGHTS. the next fishnet release will silently drop invalid castling rights.

@niklasf niklasf closed this as completed May 1, 2023
@niklasf
Copy link
Member

niklasf commented May 2, 2023

Published https://github.com/lichess-org/fishnet/releases/tag/v2.6.10 and updated our infra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ornicar @niklasf @kraktus @schlawg