Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the list button to a less used area of the lobby chart #16388

Merged
merged 10 commits into from
Nov 11, 2024

Conversation

johndoknjas
Copy link
Contributor

For me, the lobby chart looks like this:

image

This tends to make it a bit difficult to click the "list" button, since there's a good chance it'll be somewhat covered with player challenges. However, the area near the setting button is likely to be empty, due to the long time control.

@ornicar
Copy link
Collaborator

ornicar commented Nov 10, 2024

I understand the idea, but it moves the button away from where it is in the default list view. Toggling from chart to list should be at the same position as toggling from list to chart.

@johndoknjas
Copy link
Contributor Author

@ornicar That's fair enough. Would something like the following be welcome?

image

This adds a Player header, moves the chart button to where it may be more easily noticed, and gets it in the same position as the list button would be when toggled.

If it's a bit cluttered visually on the right, the Time and Mode headers could be shifted left slightly.

@ornicar
Copy link
Collaborator

ornicar commented Nov 11, 2024

It does look cluttered and unbalanced, yes.

Instead we could just increase the top value of the y axis so that all seeks get pushed down a little. Ensuring both top bar buttons are free.

@johndoknjas
Copy link
Contributor Author

johndoknjas commented Nov 11, 2024

@ornicar Sounds good, I've updated it to decrease the ratio coefficient from 94 to 92. On a laptop it looks like this for me (I gave my test challenge a 3000 rating):

image

Some overlap is still possible, but it's easier to click now. I wasn't sure if it was worth it to decrease the number further to like 90 or something.

@ornicar ornicar merged commit b1bc3c1 into lichess-org:master Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants