-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the list button to a less used area of the lobby chart #16388
Conversation
I understand the idea, but it moves the button away from where it is in the default list view. Toggling from chart to list should be at the same position as toggling from list to chart. |
@ornicar That's fair enough. Would something like the following be welcome? This adds a If it's a bit cluttered visually on the right, the |
It does look cluttered and unbalanced, yes. Instead we could just increase the top value of the y axis so that all seeks get pushed down a little. Ensuring both top bar buttons are free. |
…, slightly decrease the max height that challenge buttons may appear.
…into move-list-button
@ornicar Sounds good, I've updated it to decrease the ratio coefficient from 94 to 92. On a laptop it looks like this for me (I gave my test challenge a 3000 rating): Some overlap is still possible, but it's easier to click now. I wasn't sure if it was worth it to decrease the number further to like 90 or something. |
For me, the lobby chart looks like this:
This tends to make it a bit difficult to click the "list" button, since there's a good chance it'll be somewhat covered with player challenges. However, the area near the setting button is likely to be empty, due to the long time control.