Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate trainer adjustements #1041

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

julien4215
Copy link
Contributor

  • Style changes for the time progress bar and the settings
  • Show score at the end
  • New training in random mode recomputes a random side (consistent with the website)

@julien4215
Copy link
Contributor Author

julien4215 commented Sep 21, 2024

before.mp4
after.mp4

…e orientation when abort or new training button is pressed instead of start training
@julien4215
Copy link
Contributor Author

julien4215 commented Oct 7, 2024

I am trying to find a better layout to avoid overflows. I moved the show coordinates and show pieces toggles to settings because I thought that made more sense and since space was lacking below the board I thought that could be a good idea to move the side and time choices in the tune icon that was not used anymore.

layout.webm

@veloce
Copy link
Contributor

veloce commented Oct 7, 2024

I don't really understand the conflicts here @julien4215 . Can you have a look? Thanks :)

@julien4215
Copy link
Contributor Author

I still didn't push my changes. I'd like to know first if you prefer the new layout I posted in my last message. I am not sure about it since it makes the side and time choices less accessible.

@veloce
Copy link
Contributor

veloce commented Oct 7, 2024

I still didn't push my changes. I'd like to know first if you prefer the new layout I posted in my last message. I am not sure about it since it makes the side and time choices less accessible.

Oops I missed that, I'm sorry. Yes I think it is fine as it is in your last recording.

@julien4215 julien4215 closed this Oct 8, 2024
@julien4215 julien4215 reopened this Oct 8, 2024
@julien4215 julien4215 marked this pull request as draft October 8, 2024 07:29
@julien4215 julien4215 marked this pull request as ready for review October 8, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants