Add python 2/3 trove classifiers #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lidaobing Any luck reviewing this? The well-known Py3Readiness site is considering an increase in the number of packages displayed in chhantyal/py3readiness#40 (see preview) which would result in this package, one of the 1000 most downloaded on PyPI, to be included within the few remaining packages that do not support Python 3 when it in fact does just fine. Thanks! |
hugovk
approved these changes
Nov 18, 2019
|
@proinsias To maximize the changes of this getting merged as is, I'd recommend just squashing (fixup-ing) the two tiny fixes into your first commit, since they are so trivial, have rather unclear commit messages and (at least for the whitespace) fix a minor style issue induced by the original commit). |
Clearly identify this project as supporting python 2 and 3. This is useful for utility programs like [caniusepython3](https://github.com/brettcannon/caniusepython3#how-do-you-tell-if-a-project-has-been-ported-to-python-3). Includes changes suggested by Hugo van Kemenade <hugovk@users.noreply.github.com>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearly identify this project as supporting python 2 and 3.
This is useful for utility programs like caniusepython3.