Fix config(exclude=…) type annotations #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently I’m not the first to submit this. |
|
hi @andersk could you please update your PR so we can review and merge :) |
• The exclude callback takes one argument, not two. • Objects of type Exclude are not accepted. ALWAYS and NEVER have type Callable, not Exclude. • Class variables like Exclude.ALWAYS, Exclude.NEVER are not allowed to be generic, and they don’t need to be, since Callable[[object], bool] is convertible to Callable[[T], bool]. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
|
@george-zubrienko Rebased. |
george-zubrienko
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excludecallback takes one argument, not two.Excludeare not accepted.ALWAYSandNEVERhave typeCallable, notExclude.Exclude.ALWAYS,Exclude.NEVERare not allowed to be generic, and they don’t need to be, sinceCallable[[object], bool]is convertible toCallable[[T], bool].