shortcuts work except for next song

[cereal2nd]

all shortcuts seem to work, except ctrl+shift+0 this one is not responding

[lidel]

Hi, I was unable to reproduce, need more information from you:

• What is the version of your browser?
• Could you provide URL at which the issue occurs?

[cereal2nd]

firefox version: 58.0b4 (64-bit)

what do you mean the url?
this is the google play music url: https://play.google.com/music/listen?u=0#/home

Note i also have the containers plugin running

[lidel]

Thanks, I'll try to replicate it with Firefox Beta later today.

The URL is different depending on which Google Music Page you are on.
For example an album has a dedicated hash so that you can bookmark it.

Are you experiencing the problem for both URLs below?

• https://play.google.com/music/listen?u=0#/home
• https://play.google.com/music/listen?u=0#/album/Bedelofbqna3m2n4bvti5c2ua4u

[cereal2nd]

yes i have it on both of the urls

…

On Mon, Nov 27, 2017 at 10:22 AM Marcin Rataj ***@***.***> wrote: Thanks, I'll try to replicate it with Firefox Beta later today. The URL is different depending on which Google Music Page you are on. For example an album has a dedicated hash so that you can bookmark it. Are you experiencing the problem for both URLs below? - https://play.google.com/music/listen?u=0#/home - https://play.google.com/music/listen?u=0#/album/Bedelofbqna3m2n4bvti5c2ua4u — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADiy8RxHpCQI2v3Ogn-SBJ4YKYNbo1ijks5s6n9GgaJpZM4QrRbw> .

[lidel]

Did my best, but I was unable to replicate under v58.0b6 with containers plugin.
Tried on two machines (one Windows, one Linux).

Are you running any other extensions in Firefox? What is your operating system?
I suspect something is hijacking ctrl+shift+0 on your machine.

[lidel]

@cereal2nd I assume the issue is gone? If not, please reopen with more info.

[cereal2nd]

No the issue is still there.

…

On Dec 14, 2017, 00:42, at 00:42, Marcin Rataj ***@***.***> wrote: Closed #3. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #3 (comment)

[harpratap]

I'm having the same issue. Firefox 57.0.2 running on Windows 10. Only Ctrl+Shift+0 does not work.

[lidel]

Ok, it seems CTRL+SHIFT+0 is hijacked by.. MS Windows (are you both using it?).
The shortcut lets you switch the input language.

Good news is that you can disable it, see instructions below:

• https://support.microsoft.com/en-us/help/967893/input-method-editor-keyboard-shortcut-ctrl-shift-0-switches-the-input
• https://www.eightforums.com/general-support/22552-cant-use-ctrl-shift-0-windows-has.html

Let me know if it helped.

[harpratap]

It works on Firefox and Chrome now, thanks!

[lidel]

Awesome, glad it helped!

[lidel]

I am afraid this workaround is not enough. Even tho I've added this information to extension's description at AMO, users are missing it and giving bad reviews :(

Until #1 is closed we can't customize shortcuts under Firefox. What if we add a second set of shortcuts so that users have at least one working set out-of-the box in MS Windows?

• What set of keys would be appropriate as a backup?
• Or maybe just provide a backup alternative for the problematic one (play next)?
  Would CTRL+SHIFT+- work?

[harpratap]

Yes either that or CTRL + SHIFT + [
Both are good choices

[lidel]

Unfortunately shortcuts with [ are not permitted under Firefox:

ERROR Loading extension 'null': Reading manifest: Error processing commands.previous-song-backup.suggested_key.default: Value "Ctrl+Shift+[" must either: match the pattern /^\s*(Alt|Ctrl|Command|MacCtrl)\s*+\s*(Shift\s*+\s*)?([A-Z0-9]|Comma|Period|Home|End|PageUp|PageDown|Space|Insert|Delete|Up|Down|Left|Right)\s*$/, match the pattern /^\s*((Alt|Ctrl|Command|MacCtrl)\s*+\s*)?(Shift\s*+\s*)?(F[1-9]|F1[0-2])\s*$/, or match the pattern /^(MediaNextTrack|MediaPlayPause|MediaPrevTrack|MediaStop)$/

What about ALT+SHIFT+0? Would that work under Windows 10?

[harpratap]

Sorry, I don't have windows 10 to test this out. Personally, I would prefer CTRL + SHIF + -

[lidel]

I've released v1.5.0 with additional set of shortcuts prefixed with Alt+Shift:

• toggle playback: Ctrl+Shift+8 OR Alt+Shift+8, visual hint: *
• previous song: Ctrl+Shift+9 OR Alt+Shift+9, visual hint: (
• next song: Ctrl+Shift+0 OR Alt+Shift+0, visual hint: )

Hopefully this will prove to be flexible enough to work on all platforms until #1 is fixed in Firefox.
Feel free to reopen this issue if none of the above work for you.

[lidel]

FYSA just released v1.6.0 which enables users to customize shortcut keys under Firefox (see #1 (comment) for more details).

To make it work I had to do two changes that may impact Windows users:

1. I removed backup set of shortcuts (you can customize original ones, so there is no need for them)
2. I changed the default shortcuts under windows to Alt+Shift ones to avoid issue with Ctrl+Shift+0 and make it work out-of-the-box for new users. You can always change them anyway, so it should not be a big problem.

I hope this small shakeup will not annoy anyone too much :)