-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect tests to CI #18
Conversation
2a8e9cc
to
7663377
Compare
Should suppress Github warnings (e.g https://github.com/lidofinance/core/actions/runs/7816504140)
# Conflicts: # lib/eip712.ts
@Vinnie161, can you please assist me in resolving an error I am facing? The error message is available at this URL: https://github.com/lidofinance/core/actions/runs/7829024030/job/21360112586?pr=18. I believe repository security settings require some changes to enable SARIF file uploads. As this is a private repository, the security settings may differ from Also, would appreciate it if you could review the GitHub Actions workflow jobs. cc: @TheDZhon |
@Vinnie161, there is an error on the runner side: github/codeql-action#2117, so probably nothing can be done for now. Waiting for the fix from |
# Conflicts: # lib/ec.ts
d20acce
to
c14cd69
Compare
🧪 Test coverage: 14.60% Code Coverage Summary
Results for commit: 08faf9c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
6eabe2c
to
f00c20a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Splendid! 👍
I'd suggest implementing a small set of changes before merging this PR 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
Changes:
Added CI contract validation with Slither(disabled because of the bug on GitHub side codeql/upload-sarif@v3 action failed: Resource not accessible by integration - missingactions: read
github/codeql-action#2117)Misc:
Recommendation:
Settings | Languages & Frameworks | JavaScript | Code Quality Tools | ESLint | Run eslint --fix on save