-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Lido V2 initial docs rework [batch 1] #212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TheDZhon
commented
May 18, 2023
•
edited
Loading
edited
- Rename contracts
- Update sidebar
- Remove Terra mentions 🌚
- Remove Rinkeby, Kovan, and Ropsten deployments (testnets are discontinued)
- Remove stETH/ETH deprecated price oracle mentions
- Stubs for the new and outdated contracts
- Remove 'withdrawals aren't available yet claims' and include withdrawals support feature here and there as a part of the protocol
- Some incomplete edits and attempts to catch up on the current protocol state 😞
Ropsten, Kovan, and Rinkeby are all discontinued.
5aa83f4
to
b09dacb
Compare
folkyatina
reviewed
Jun 20, 2023
folkyatina
reviewed
Jun 20, 2023
folkyatina
reviewed
Jun 20, 2023
folkyatina
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left several comments, but it's much better than it was. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.