Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity warnings fixes #99

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Solidity warnings fixes #99

merged 1 commit into from
Aug 20, 2024

Conversation

rkolpakov
Copy link
Contributor

All problems with solc warnings were fixed except one:

function now() internal view returns (Timestamp res)
This declaration shadows a builtin symbol.solidity (2319)

In previous versions of Solidity there was block.now() method so Timestamp.now() seems to shadow overrides it. There is no possible solution to drown that warning so possible solutions:

  1. leave it as is;
  2. change now to something like current.

@rkolpakov rkolpakov changed the title fix: solidity warnings fixes Solidity warnings fixes Aug 16, 2024
@Psirex
Copy link
Contributor

Psirex commented Aug 19, 2024

I would personally leave it as is. The now() method is deprecated and can't be used, plus the method is declared in the library, not in the global scope.

@rkolpakov rkolpakov merged commit 48f8438 into develop Aug 20, 2024
2 checks passed
@Psirex Psirex mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants