-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon of senders #140
Comments
Currently this is hard coded into the add-on (mapping: https://github.com/lieser/dkim_verifier/blob/master/data/favicon.json, icons in https://github.com/lieser/dkim_verifier/tree/master/data/favicon). There already exist an issue to change this: #83. At the moment you can either add them there yourself and create a pull request, or ask me to add sites. Note that E-Mail providers will not be added to the favicon list until #107 is resolved. I also do not add personal sites. |
I see that some of the sites that I want are already on the list but they still do not display the icon in my e-mails. Mail of the one present but not working:
Missing icon:
|
Thanks for the list of missing domains. I will add them in the next release.
|
There are also others missing: |
Thanks a gain for the list of missing domains. Will add them too.
I would recommend enabling the caching of the DKIM keys to avoid this problem. See https://github.com/lieser/dkim_verifier/wiki/Options#caching-of-the-dkim-keys. I have the key used at that time by mozilla cached locally, and verification and showing of the icon works without problems for the e-mail you send me. I would suggest to postpone further investigation for now, until you have again problems with the icon for an e-mail where verification passes. |
Might want to add (email.|)f-secure.com |
I updated the favicons and default rules. This should also fix #145. Would be nice if you could try it out before I release it. You can get the pre release from dkim_verifier-2.0.2pre1.zip @ale5000-git Also for the default rules, please tell me if the following are not just signed by the top domain, but the complete domain of the e-mail address:
The following there already in the favicon rules, and should have already be showing the favicon:
@mortenn |
I have done some tests and the new pre release seems to work fine. I have also found other domains to add: Missing sign rule and icon:
Missing only icon:
|
Thanks a lot for the additional domains and information. Will take a lock at it the next days, and add them. About the problems:
|
About Microsoft apparently some mail got correct DKIM while some other no, it may be a bug in their mail server. I also found some other domains: Missing sign rule and icon:
Missing only icon:
|
It is signed by email.f-secure.com
|
But I expect email from @f-secure.com is signed for non-automated email as well. |
Thank you both for the additional information. Will probably release a new version with this included in the next week. Or you can already try the pre release attached here dkim_verifier-2.1.0pre1.zip (Note that this version includes #141, so you may see some new warnings). @ale5000-git
For the following I only added the favicon, as I'm unsure if all e-mails from this domains are signed:
For the others I added both the favicon and a default rule. |
I have tested all new icons in the pre-release and everything is working properly, thanks :) For consultingroupitaly.com mails, see #154 |
I see it display an icon near the sender of mails received from LinkedIn.
How to add it also to other mails?
The text was updated successfully, but these errors were encountered: