Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From address is ill formed. Really? #304

Closed
alevesely opened this issue May 16, 2022 · 3 comments
Closed

From address is ill formed. Really? #304

alevesely opened this issue May 16, 2022 · 3 comments
Assignees
Labels
Milestone

Comments

@alevesely
Copy link

From: Alessandro Vesely <vesely@tana.it>, 2nd name <user@example.com>

I think the add-on complaints about multiple mailboxes, which are allowed by RFC5322. It displays From address is ill formed. (For obscure reasons, DMARC does not consider this case, but DKIM says nothing about that, IIRC). The Authentication-Results: header said dkim=pass. Error console says:

Promise rejected after context unloaded: Actor 'Conduits' destroyed before query 'RuntimeMessage' was resolved [displayAction.mjs.js:45](moz-extension://694bf5d4-0ccd-4013-88d6-a4fdb3a218aa/content/displayAction.mjs.js)
    triggerDisplayAction moz-extension://694bf5d4-0ccd-4013-88d6-a4fdb3a218aa/content/displayAction.mjs.js:45

DKIM_Verifier.AuthVerifier	ERROR	 Parsing of from header failed <unavailable> [authVerifier.mjs.js:133:8](moz-extension://694bf5d4-0ccd-4013-88d6-a4fdb3a218aa/modules/authVerifier.mjs.js)
    verify moz-extension://694bf5d4-0ccd-4013-88d6-a4fdb3a218aa/modules/authVerifier.mjs.js:133
​
@lieser
Copy link
Owner

lieser commented May 16, 2022

The From header is probably valid, as not handling mailbox-list is a known limitation.
Never saw such an headed, so hoped I could get away with not handling it.

Will try to fix this in the next version.

@lieser lieser self-assigned this May 16, 2022
@lieser lieser added the bug label May 16, 2022
@lieser lieser added this to the 4.2.0 milestone May 16, 2022
@lieser
Copy link
Owner

lieser commented May 22, 2022

The issue should be fixed. Note that I decided to simply ignore all but the first address for e.g. the sign rules. By default Thunderbird seems to also only display the first address.

@lieser lieser closed this as completed May 22, 2022
@alevesely
Copy link
Author

I agree that's the simplest way to treat it. Some argue that, in the rare cases where multiple authorship is needed, the order can be important. In such cases, it is necessary that the message be actually sent by the first author.

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants