Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some favicons and sign rules (on ver. 4) #263

Merged
merged 3 commits into from
Jun 6, 2021
Merged

Added some favicons and sign rules (on ver. 4) #263

merged 3 commits into from
Jun 6, 2021

Conversation

dodmi
Copy link
Contributor

@dodmi dodmi commented May 30, 2021

and sorted them alphabetically by "main" domain

@dodmi dodmi changed the title Added some favicons and sign rules Added some favicons and sign rules (on ver. 4) May 30, 2021
lieser
lieser requested changes May 31, 2021
View reviewed changes
Copy link
Owner

@lieser lieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new rules/icons, and fixing the sorting order.

I have some small questions, but looks good overall.

data/favicon.json Outdated Show resolved Hide resolved
data/signersDefault.json Show resolved Hide resolved
data/signersDefault.json Outdated Show resolved Hide resolved
@dodmi
Copy link
Contributor Author

dodmi commented May 31, 2021

Based on your decision(s), I'd change the rules to be more general.
And probably the favicon domain...
Please add a short comment, what you prefer.

@dodmi dodmi requested a review from lieser June 2, 2021 17:35
@dodmi
Copy link
Contributor Author

dodmi commented Jun 3, 2021

Hi,
I prefer doing it consistent with your habit to add rules. Thank you for your insights.

@dodmi dodmi mentioned this pull request Jun 3, 2021
Merged
lieser
lieser reviewed Jun 6, 2021
View reviewed changes
data/signersDefault.json Outdated Show resolved Hide resolved
@lieser
Copy link
Owner

lieser commented Jun 6, 2021

Thanks for the additional effort for making it consistent. Unfortunately the two rules for cacf-festgeld.de now have priorities that hide the more concrete one.

@dodmi
Copy link
Contributor Author

dodmi commented Jun 6, 2021

Ok, I've changed the rule types.

@lieser lieser merged commit 6e1cf81 into lieser:master Jun 6, 2021
@lieser lieser self-assigned this Jun 6, 2021
@dodmi dodmi deleted the updFavIcons-4.x-2021-05-30 branch June 6, 2021 20:58
@lieser lieser added this to the 4.1.0 milestone Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieser lieser lieser approved these changes

Assignees

@lieser lieser

Labels
default sign rules/favicon
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dodmi @lieser