Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated some favicons and rules #281

Merged
merged 10 commits into from
Dec 18, 2021
Merged

Conversation

dodmi
Copy link
Contributor

@dodmi dodmi commented Dec 18, 2021

No description provided.

@lieser
Copy link
Owner

lieser commented Dec 18, 2021

Thanks for the updated favicons and rules.

There did you get the icon for rcibanque.com? If I go to that site I'm forwarded to https://www.rcibs.com/fr, which seems to use an orange circle as an icon, not the Renault symbol.

@lieser lieser added this to the 4.1.0 milestone Dec 18, 2021
@dodmi
Copy link
Contributor Author

dodmi commented Dec 18, 2021

Well, actually the support from "Renault-Bank-Direkt" sends mails from the domain rcibanque.com.
So, I took the one from www.renault-bank-direkt.de, but I just saw, they have changed their web design, since I added the icon. It's now black and white.
So, shall I change it to the orange circle?

@lieser
Copy link
Owner

lieser commented Dec 18, 2021

It looks like rcibanque.com could also send mails not related to www.renault-bank-direkt.de, so I think the orange circle representing RCI Banque is a better fit.

@lieser lieser merged commit 1e1e9d7 into lieser:master Dec 18, 2021
@dodmi dodmi deleted the updFavIcons-4.x-2021-12-18 branch December 19, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants