Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate env to improve AWS IMDS interaction #24

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

mageshwaran-lifebit
Copy link

@mageshwaran-lifebit mageshwaran-lifebit commented Jan 2, 2024

Copy link
Collaborator

@tiagofilipe12 tiagofilipe12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly this comment here needs to be sorted before closing this ticket: https://lifebit.atlassian.net/browse/LP-6169?focusedCommentId=82322

@mageshwaran-lifebit
Copy link
Author

Mainly this comment here needs to be sorted before closing this ticket: https://lifebit.atlassian.net/browse/LP-6169?focusedCommentId=82322

@tiagofilipe12 added document https://lifebit.atlassian.net/browse/LP-6169?focusedCommentId=82405

Copy link
Collaborator

@tiagofilipe12 tiagofilipe12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but is the pipeline meant to be failing?

@mageshwaran-lifebit
Copy link
Author

Lgtm, but is the pipeline meant to be failing?

Now test is fixed.

@mageshwaran-lifebit mageshwaran-lifebit merged commit 6ea3ab1 into 21.04.1 Jan 4, 2024
3 checks passed
@mageshwaran-lifebit mageshwaran-lifebit deleted the LP-6243 branch January 4, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants