-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build react and native components as separate packages #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks 🙌
Due to the import change for react-native
, how would you feel about making this a breaking change with conventional commits (https://www.conventionalcommits.org/en/v1.0.0/) so we get a major version bump instead? I don't imagine anyone was using the latest version yet, but just in case to follow semantic versioning.
Do you know how the Releases
section will work after this, since it's now two packages? Not a deal breaker by any means, just curious (https://github.com/lifeomic/chromicons/releases)
@@ -33,13 +33,13 @@ import { Apple } from '@lifeomic/chromicons'; | |||
1. Install Dependencies | |||
|
|||
```bash | |||
yarn add @lifeomic/chromicons react-native-svg | |||
yarn add @lifeomic/chromicons-native |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Merging this PR will result in a major version bump. Created by lifeomic-probot (Enforce Semantic Commits) |
BREAKING CHANGE: previous versions shipped with both react and react-native components but now they are published individually
0743441
to
21573a2
Compare
@ynotdraw I realized I was applying the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! No worries about the release section either, was just curious!
Here we go 🤞 |
Commands
yarn build
- invokes the react and native build commandsbuild:react
- invokes a build of just the react component files (generated by thegenerate:react-components
cmd)postbuild:react
build/react
folderdist
folder (created bytsdx
) into thebuild/react
foldersrc/build/react
folder (created bygenerate:react-components
) into thebuild/react/src
folder\postbuild
- calls theprepare-packages.js
script which copies and transforms the required package metadata files (LICENSE, README.md, and package.json)The
native
commands operate similarly to thereact
commands