LPS-145293 Add support for deployment of custom elements as ES modules #1916

izaera · 2022-02-15T11:21:02Z

⚠⚠ NO NEED TO REVIEW THIS, IT WAS ALREADY REVIEWED IN A PREVIOUS PR ⚠⚠

This adds a new boolean field so that custom element remote apps may be bootstrapped using <script type="module"> as opposed to plain vanilla JavaScript.

This is needed for:

The new JS Toolkit build for Remote Apps that lets developers consume react from the portal
Angular projects for version >=13 that need this feature
Any other deployment that wants to leverage ESM

The simplest way to test that this works would be creating a new remote app, checking "Use ES modules":

and then looking at how the <script> tag is rendered:

…type="module"> Note that I'm using a TopHeadDynamicInclude to render the portlet's .js files because we cannot use the standard mechanisms based on portlet's properties as those are only intended for plain JavaScript files. The TopHeadDynamicInclude registers URLs whenever a new RemoteAppEntryPortlet is deployed and the cleanup is made when the Portlet is destroyed (listening to the event using OSGi). We keep reference counts to each URL so that if more than one portlet refers to the same JS URL, it is not removed from the page until all portlets have been unregistered.

Although it is not failing now, we need to make sure that the importmap node appears before any other <script> node so I'm setting this to the maximum value to make it appear on top of any other DynamicInclude. This is because it is very likely that in the future we render ESM <script> nodes from DynamicIncludes.

izaera · 2022-02-15T11:22:51Z

ci:test:sf

liferay-continuous-integration · 2022-02-15T11:22:52Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2022-02-15T11:27:55Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6345c62ea4e608c6cd23db768242a45552e4d324

Sender Branch:

Branch Name: LPS-145293-1
Branch GIT ID: 6b751ad1cf2d41de81d98b10fad9c8aca511183a

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2022-02-15T11:29:29Z

Jenkins Build:test-portal-source-format#1809

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#1916

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - izaera > liferay-frontend - PR#1916 - 2022-02-15[03:24:13]

Testray Importer:publish-testray-report#6628

liferay-continuous-integration · 2022-02-15T11:29:44Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6345c62ea4e608c6cd23db768242a45552e4d324

Sender Branch:

Branch Name: LPS-145293-1
Branch GIT ID: 6b751ad1cf2d41de81d98b10fad9c8aca511183a

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2022-02-15T11:31:25Z

Jenkins Build:test-portal-source-format#1809

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#1916

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - izaera > liferay-frontend - PR#1916 - 2022-02-15[03:24:13]

Testray Importer:publish-testray-report#6629

magjed4289 · 2022-02-15T11:31:46Z

Just started reviewing :)

liferay-continuous-integration · 2022-02-15T11:32:43Z

Jenkins Build:test-portal-source-format#1810

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#1916

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - izaera > liferay-frontend - PR#1916 - 2022-02-15[03:25:20]

Testray Importer:publish-testray-report#6630

liferay-continuous-integration · 2022-02-15T11:33:59Z

Jenkins Build:test-portal-source-format#1810

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#1916

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - izaera > liferay-frontend - PR#1916 - 2022-02-15[03:25:20]

Testray Importer:publish-testray-report#6631

magjed4289 · 2022-02-17T09:30:36Z

ci:test:relevant

liferay-continuous-integration · 2022-02-17T11:12:27Z

❌ ci:test:stable - 24 out of 28 jobs passed

❌ ci:test:relevant - 24 out of 29 jobs passed in 2 hours 7 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1337401_1096

Base Branch:

Branch Name: master
Branch GIT ID: 3b5cfe0822faf8e57b7ef5c35189a0a26f58536b

Upstream Comparison:

Branch GIT ID: 233dea919ef0ab6061f0b27121e3b76d3b960383
Jenkins Build URL: Acceptance Upstream DXP (master) #2924

ci:test:stable - 24 out of 28 jobs PASSED

4 Failed Jobs:

24 Successful Jobs:

ci:test:relevant - 24 out of 29 jobs PASSED

5 Failed Jobs:

24 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #399756

     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:dynamic-data-mapping:dynamic-data-mapping-form-field-type:packageRunTest'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:dynamic-data-mapping:dynamic-data-mapping-form-field-type:packageRunTest'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)
     [exec]   at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)
     [exec]   at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
     [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
     [exec]   at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
     [exec]   at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
     [exec]   at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
     [exec]   at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:409)

test-portal-acceptance-pullrequest-batch(master)/unit-jdk8/0

Job Results:

2335 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #476854

junit.framework.TestSuite.com.liferay.portal.kernel.util.URLCodecTest

junit.framework.AssertionFailedError: com.liferay.portal.kernel.util.URLCodec is not fully covered
  at com.liferay.whip.agent.InstrumentationAgent._assertClassDataCoverage(InstrumentationAgent.java:343)
  at com.liferay.whip.agent.InstrumentationAgent.assertCoverage(InstrumentationAgent.java:66)
  at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor.afterClass(CodeCoverageAssertor.java:119)
  at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor$1.evaluate(CodeCoverageAssertor.java:84)

Failures in common with acceptance upstream results at 233dea9:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

2 Tests Passed.
3 Tests Failed.

AXIS_VARIABLE=0 #488796

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1645094910003.log: !SESSION 2022-02-17 10:48:47.724 ----------------------------------------------- eclipse.buildId=unknown java.version=1.8.0_121 java.vendor=Oracle Corporation BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US !ENTRY com.liferay.exportimport.service 4 0 2022-02-17 10:48:47.724 !MESSAGE FrameworkEvent ERROR !STACK 0 org.osgi.framework.BundleException: Could not resolve module: com.liferay.exportimport.service [94] Unresolved requirement: Import-Package: com.thoughtworks.xstream; version="1.4.0" at org.eclipse.osgi.container.Module.start(Module.java:444) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1) at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230) at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

!ENTRY com.liferay.portal.odata.im...

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: FrameworkEvent ERROR org.osgi.framework.BundleException: Could not resolve module: com.liferay.exportimport.service [94] Unresolved requirement: Import-Package: com.thoughtworks.xstream; version="1.4.0" at org.eclipse.osgi.container.Module.start(Module.java:444) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1) at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230) at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171) at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98) at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88) at java.nio.file.Files.walkFileTree(Files.java:2670) at java.nio.file.Files.walkFileTree(Files.java:2742) at com.liferay.portal.log.assertor.PortalLogAs...

LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

466 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=1 #34634

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError:

The type property is deprecated. Use the DBType property instead.

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)

at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)

at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)

at java.nio.file.Files.walkFileTree(Files.java:2670)

at java.nio.file.Files.walkFileTree(Files.java:2742)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

test-portal-acceptance-pullrequest-batch(master)/unit-jdk8/0

Job Results:

2335 Tests Passed.
4 Tests Failed.

AXIS_VARIABLE=0 #476854

com.liferay.portal.kernel.util.URLCodecTest.testDecodeURL

junit.framework.AssertionFailedError: expected:<[java.nio.charset.UnmappableCharacterException: ]Input length = 1> but was:<[]Input length = 1>

at com.liferay.portal.kernel.util.URLCodecTest._testCharacterCodingException(URLCodecTest.java:186)

at com.liferay.portal.kernel.util.URLCodecTest.testDecodeURL(URLCodecTest.java:81)

at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor$1.evaluate(CodeCoverageAssertor.java:81)

com.liferay.portal.kernel.util.URLCodecTest.testEncodeURL

junit.framework.AssertionFailedError: expected:<[java.nio.charset.UnmappableCharacterException: ]Input length = 1> but was:<[]Input length = 1>

at com.liferay.portal.kernel.util.URLCodecTest._testCharacterCodingException(URLCodecTest.java:186)

at com.liferay.portal.kernel.util.URLCodecTest.testEncodeURL(URLCodecTest.java:124)

at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor$1.evaluate(CodeCoverageAssertor.java:81)

com.liferay.portal.kernel.servlet.SessionMapsTest.testInvalidatedSession

junit.framework.AssertionFailedError: expected:<[java.lang.IllegalStateException: ]Invalidated> but was:<[]Invalidated>

at com.liferay.portal.kernel.servlet.SessionMapsTest.testInvalidatedSession(SessionMapsTest.java:133)

at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)

at com.liferay.portal.kernel.test.rule.AbstractTestRule$1.evaluate(AbstractTestRule.java:59)

at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor$1.evaluate(CodeCoverageAssertor.java:81)

...

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-02-17T11:20:22Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#1096

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#1916

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - izaera > liferay-frontend - PR#1916 - 2022-02-17[01:04:07]

Testray Importer:publish-testray-report#3176

magjed4289 · 2022-02-17T11:48:02Z

Reviewed. Test failures are unrelated. ✔️
Ok to manually forward.

magjed4289 · 2022-02-17T11:49:09Z

ci:test:stable

liferay-continuous-integration · 2022-02-17T12:35:53Z

❌ ci:test:stable - 24 out of 28 jobs passed

❌ ci:test:relevant - 24 out of 29 jobs passed in 3 hours 3 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1327401_2544

Base Branch:

Branch Name: master
Branch GIT ID: 3b5cfe0822faf8e57b7ef5c35189a0a26f58536b

Upstream Comparison:

Branch GIT ID: 233dea919ef0ab6061f0b27121e3b76d3b960383
Jenkins Build URL: Acceptance Upstream DXP (master) #2924

ci:test:stable - 24 out of 28 jobs PASSED

4 Failed Jobs:

24 Successful Jobs:

ci:test:relevant - 24 out of 29 jobs PASSED

5 Failed Jobs:

24 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #11580

     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:dynamic-data-mapping:dynamic-data-mapping-form-field-type:packageRunTest'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:dynamic-data-mapping:dynamic-data-mapping-form-field-type:packageRunTest'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)
     [exec]   at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)
     [exec]   at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
     [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
     [exec]   at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
     [exec]   at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
     [exec]   at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
     [exec]   at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:409)

test-portal-acceptance-pullrequest-batch(master)/unit-jdk8/0

Job Results:

2335 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #33807

junit.framework.TestSuite.com.liferay.portal.kernel.util.URLCodecTest

junit.framework.AssertionFailedError: com.liferay.portal.kernel.util.URLCodec is not fully covered
  at com.liferay.whip.agent.InstrumentationAgent._assertClassDataCoverage(InstrumentationAgent.java:343)
  at com.liferay.whip.agent.InstrumentationAgent.assertCoverage(InstrumentationAgent.java:66)
  at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor.afterClass(CodeCoverageAssertor.java:119)
  at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor$1.evaluate(CodeCoverageAssertor.java:84)

Failures in common with acceptance upstream results at 233dea9:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

2 Tests Passed.
3 Tests Failed.

AXIS_VARIABLE=0 #31153

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: 
Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1645097013846.log:
!SESSION 2022-02-17 11:23:51.021 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_121
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
!ENTRY com.liferay.portal.odata.impl 4 0 2022-02-17 11:23:51.022

!MESSAGE FrameworkEvent ERROR

!STACK 0

org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.odata.impl [233]

Unresolved requirement: Import-Package: io.netty.buffer
at org.eclipse.osgi.container.Module.start(Module.java:444)

at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)

at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)

at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)

at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)

at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)

at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)

at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
!ENTRY com.liferay.site.initializer.extender 4 0 2022-02-17 11:23...

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: FrameworkEvent ERROR org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.odata.impl [233] Unresolved requirement: Import-Package: io.netty.buffer at org.eclipse.osgi.container.Module.start(Module.java:444) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1) at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230) at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171) at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98) at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88) at java.nio.file.Files.walkFileTree(Files.java:2670) at java.nio.file.Files.walkFileTree(Files.java:2742) at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(Po...

LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

466 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=1 #29198

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError:

The type property is deprecated. Use the DBType property instead.

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)

at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)

at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)

at java.nio.file.Files.walkFileTree(Files.java:2670)

at java.nio.file.Files.walkFileTree(Files.java:2742)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

test-portal-acceptance-pullrequest-batch(master)/unit-jdk8/0

Job Results:

2335 Tests Passed.
4 Tests Failed.

AXIS_VARIABLE=0 #33807

com.liferay.portal.kernel.util.URLCodecTest.testDecodeURL

junit.framework.AssertionFailedError: expected:<[java.nio.charset.UnmappableCharacterException: ]Input length = 1> but was:<[]Input length = 1>

at com.liferay.portal.kernel.util.URLCodecTest._testCharacterCodingException(URLCodecTest.java:186)

at com.liferay.portal.kernel.util.URLCodecTest.testDecodeURL(URLCodecTest.java:81)

at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor$1.evaluate(CodeCoverageAssertor.java:81)

com.liferay.portal.kernel.util.URLCodecTest.testEncodeURL

junit.framework.AssertionFailedError: expected:<[java.nio.charset.UnmappableCharacterException: ]Input length = 1> but was:<[]Input length = 1>

at com.liferay.portal.kernel.util.URLCodecTest._testCharacterCodingException(URLCodecTest.java:186)

at com.liferay.portal.kernel.util.URLCodecTest.testEncodeURL(URLCodecTest.java:124)

at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor$1.evaluate(CodeCoverageAssertor.java:81)

com.liferay.portal.kernel.servlet.SessionMapsTest.testInvalidatedSession

junit.framework.AssertionFailedError: expected:<[java.lang.IllegalStateException: ]Invalidated> but was:<[]Invalidated>

at com.liferay.portal.kernel.servlet.SessionMapsTest.testInvalidatedSession(SessionMapsTest.java:133)

at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)

at com.liferay.portal.kernel.test.rule.AbstractTestRule$1.evaluate(AbstractTestRule.java:59)

at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor$1.evaluate(CodeCoverageAssertor.java:81)

...

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-02-17T12:42:32Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#2544

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#1916

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - izaera > liferay-frontend - PR#1916 - 2022-02-17[01:30:49]

Testray Importer:publish-testray-report#7884

magjed4289 · 2022-02-17T13:15:25Z

Reviewed again. Test failures are unrelated. ✔️
Ok to manually forward.

liferay-continuous-integration · 2022-02-17T13:27:17Z

✔️ ci:test:stable - 12 out of 12 jobs passed in 1 hour 38 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3b5cfe0822faf8e57b7ef5c35189a0a26f58536b

Upstream Comparison:

Branch GIT ID: 233dea919ef0ab6061f0b27121e3b76d3b960383
Jenkins Build URL: Acceptance Upstream DXP (master) #2924

ci:test:stable - 12 out of 12 jobs PASSED

12 Successful Jobs:

For more details click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-02-17T13:30:06Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#921

Jenkins Report:jenkins-report.html

Jenkins Suite:stable

Pull Request:liferay-frontend#1916

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:stable - izaera > liferay-frontend - PR#1916 - 2022-02-17[03:49:22]

Testray Importer:publish-testray-report#2950

izaera · 2022-02-17T14:51:23Z

Forwarded as brianchandotcom#113562

izaera added 9 commits February 15, 2022 10:52

LPS-145293 Add customElementUseESM field to RemoteAppEntry

fb546cb

LPS-145293 gradle buildService

8241277

LPS-145293 Implement DB upgrade process

a591ea8

LPS-145293 Adapt BundleSiteInitializer to new field

4d13f6b

LPS-145293 Implement useESM field edition in remote apps

40ca69b

LPS-145293 Add language keys

84d475c

LPS-145293 gradle buildLang

461e30a

izaera added the s-devexp label Feb 15, 2022

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - pending labels Feb 15, 2022

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - success labels Feb 15, 2022

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 15, 2022

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Feb 17, 2022

liferay-continuous-integration added ci:test:stable - pending ci:test:relevant - failure ci:test:stable - failure and removed ci:test:stable - failure ci:test:relevant - failure ci:test:stable - pending labels Feb 17, 2022

liferay-continuous-integration added ci:test:stable - success and removed ci:test:stable - failure labels Feb 17, 2022

This was referenced Feb 17, 2022

LPS-145293 Add support for deployment of custom elements as ES modules liferay/liferay-portal#4615

Closed

LPS-145293 Add support for deployment of custom elements as ES modules brianchandotcom/liferay-portal#113562

Closed

izaera closed this Feb 17, 2022

LPS-145293 Add support for deployment of custom elements as ES modules #1916

LPS-145293 Add support for deployment of custom elements as ES modules #1916

Conversation

izaera commented Feb 15, 2022 • edited Loading

izaera commented Feb 15, 2022

liferay-continuous-integration commented Feb 15, 2022

liferay-continuous-integration commented Feb 15, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 15, 2022

liferay-continuous-integration commented Feb 15, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 15, 2022

magjed4289 commented Feb 15, 2022

liferay-continuous-integration commented Feb 15, 2022

liferay-continuous-integration commented Feb 15, 2022

magjed4289 commented Feb 17, 2022

liferay-continuous-integration commented Feb 17, 2022

❌ ci:test:stable - 24 out of 28 jobs passed

❌ ci:test:relevant - 24 out of 29 jobs passed in 2 hours 7 minutes

Base Branch:

Upstream Comparison:

4 Failed Jobs:

5 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

Test bundle downloads:

liferay-continuous-integration commented Feb 17, 2022

magjed4289 commented Feb 17, 2022

magjed4289 commented Feb 17, 2022

liferay-continuous-integration commented Feb 17, 2022

❌ ci:test:stable - 24 out of 28 jobs passed

❌ ci:test:relevant - 24 out of 29 jobs passed in 3 hours 3 minutes

Base Branch:

Upstream Comparison:

4 Failed Jobs:

5 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

Test bundle downloads:

liferay-continuous-integration commented Feb 17, 2022

magjed4289 commented Feb 17, 2022

liferay-continuous-integration commented Feb 17, 2022

✔️ ci:test:stable - 12 out of 12 jobs passed in 1 hour 38 minutes

Base Branch:

Upstream Comparison:

For more details click here.

Test bundle downloads:

liferay-continuous-integration commented Feb 17, 2022

izaera commented Feb 17, 2022

izaera commented Feb 15, 2022 •

edited

Loading