Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-200853 Add jsPDF JavaScript to Portal #3847

Closed
wants to merge 1 commit into from
Closed

LPS-200853 Add jsPDF JavaScript to Portal #3847

wants to merge 1 commit into from

Conversation

thektan
Copy link

@thektan thektan commented Nov 22, 2023

https://liferay.atlassian.net/browse/LPS-200853

@bryceosterhaus originally sent: cgmonte#100

I just removed the object-web changes. I thought we could add these in so they could move forward with their story to add their feature https://liferay.atlassian.net/browse/LPS-201526. Even though the icons don't render (waiting for bubkoo/html-to-image#427 to be merged) and the only workaround is to use background images, at least that can be used for now.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 483755c2e0cb9b63f4268719d9c623d343f34e2c

Sender Branch:

Branch Name: LPS-200853_jspdf
Branch GIT ID: 393b0542b1c029f5f99ddb495eae2f2bea9c0fa6

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@thektan
Copy link
Author

thektan commented Nov 22, 2023

ci:test:relevant

bryceosterhaus
bryceosterhaus approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@bryceosterhaus bryceosterhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 30 out of 31 jobs passed

❌ ci:test:relevant - 164 out of 238 jobs passed in 4 hours 40 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9d6b6a84c3f3d28dac398d742beb5c0843b69aee

Upstream Comparison:

Branch GIT ID: 9d6b6a84c3f3d28dac398d742beb5c0843b69aee
Jenkins Build URL: EE Development Acceptance (master) - 183 - 2023-11-21[20:44:02]

ci:test:stable - 30 out of 31 jobs PASSED

1 Failed Jobs:

30 Successful Jobs:
    ci:test:relevant - 164 out of 238 jobs PASSED

    74 Failed Jobs:

    164 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      1. functional-smoke-tomcat90-hypersonic20-jdk8/0/0
        build-common-java.jar:
     [copy] Copying 1 file to /opt/dev/projects/github/liferay-portal/util-bridges/classes/META-INF/maven/com.liferay.portal/com.liferay.util.bridges
[propertyfile] Creating new property file: /opt/dev/projects/github/liferay-portal/util-bridges/classes/META-INF/maven/com.liferay.portal/com.liferay.util.bridges/pom.properties
[bnd-invoker] SLF4J: Class path contains multiple SLF4J bindings.
[bnd-invoker] SLF4J: Found binding in [jar:file:/tmp/7181413485459249653.tmp!/org/slf4j/impl/StaticLoggerBinder.class]
[bnd-invoker] SLF4J: Found binding in [jar:file:/opt/dev/projects/github/liferay-jenkins-ee/commands/../lib/jenkins/slf4j-log4j12.jar!/org/slf4j/impl/StaticLoggerBinder.class]
[bnd-invoker] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
[bnd-invoker] SLF4J: Actual binding is of type [org.slf4j.impl.SimpleLoggerFactory]
      Failures in common with acceptance upstream results at 9d6b6a8:
      5. ...
      Test bundle downloads:

      @mateusralv
      Copy link

      ci:test:relevant

      @thektan
      Copy link
      Author

      thektan commented Nov 23, 2023

      @mateusralv If failures are not related, can you help forward this? Otherwise I can take a look when I return on Monday or someone else on the team can if they have bandwidth. Thanks!

      @liferay-continuous-integration
      Copy link
      Collaborator

      ✔️ ci:test:stable - 31 out of 31 jobs passed

      ❌ ci:test:relevant - 167 out of 238 jobs passed in 2 hours 43 minutes

      Click here for more details.

      This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

      ci:reevaluate:1407401_7581

      Base Branch:

      Branch Name: master
      Branch GIT ID: 64225f6a078f09336d5580403dab175b68d3c9d9

      Upstream Comparison:

      Branch GIT ID: 38131bd1c68de68ae139a595824a7acdf2191b2c
      Jenkins Build URL: EE Development Acceptance (master) - 185 - 2023-11-22[08:42:54]

      ci:test:stable - 31 out of 31 jobs PASSED
      31 Successful Jobs:
        ci:test:relevant - 167 out of 238 jobs PASSED

        71 Failed Jobs:

        167 Successful Jobs:
          For more details click here.

          Failures unique to this pull:

          Failures in common with acceptance upstream results at 38131bd:
          4. ...
          Test bundle downloads:

          @liferay-continuous-integration
          Copy link
          Collaborator

          @mateusralv
          Copy link

          Hey @thektan The failures are not related.

          Testray Comparison

          @mateusralv
          Copy link

          ci:forward:force

          @liferay-continuous-integration
          Copy link
          Collaborator

          CI is automatically triggering the following test suites:

          •     ci:test:relevant
          •     ci:test:sf
          •     ci:test:stable

          The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

          •     ci:test:relevant
          •     ci:test:sf
            AND If the following test suites pass:
          •     ci:test:stable

          @liferay-continuous-integration
          Copy link
          Collaborator

          Skipping previously completed test suites:

          • ci:test:relevant
          • ci:test:sf
            AND Skipping previously passed test suites:
          • ci:test:stable

          @liferay-continuous-integration
          Copy link
          Collaborator

          All required test suite(s) completed.
          Forwarding pull request to brianchandotcom.
          Console

          Merged
          @liferay-continuous-integration
          Copy link
          Collaborator

          Pull request has been successfully forwarded to brianchandotcom#144302
          Console

          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
          Reviewers

          @bryceosterhaus bryceosterhaus bryceosterhaus approved these changes

          Assignees
          No one assigned
          Labels
          ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
          Projects
          None yet
          Milestone
          No milestone
          Development

          Successfully merging this pull request may close these issues.
          4 participants
          @thektan @liferay-continuous-integration @mateusralv @bryceosterhaus