Fixes #1941 - Implement panel component with collapse ability

[bryceosterhaus]

I haven't added the animation for the height expanding yet. Wanted to make sure this was the route we wanted to go first.

[coveralls]

Pull Request Test Coverage Report for Build 2488

• 41 of 41 (100.0%) changed or added relevant lines in 6 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+2.2%) to 81.707%

---

Totals
Change from base Build 2486:	2.2%
Covered Lines:	751
Relevant Lines:	883

---

💛 - Coveralls

[matuzalemsteles]

Just started reviewing :)

Sent from GH.

[matuzalemsteles]

hey @bryceosterhaus this component looks good to me but I'm not sure if we should follow with Panel implemented with Collapse or just a hook for the Collapse, I do not know what use cases it had or if it was used.

But it's fine with me if we go with that, since it no longer makes sense in the context of React to write as it was before.

[bryceosterhaus]

@matuzalemsteles I think we just keep collapse prop for panel. We can extract the transition height logic to its own hook and share it throughout clay though. I will wait for Diegos PR for navigation bar since he has a similar hook for transitioning height.

[bryceosterhaus]

@matuzalemsteles updated.

I went ahead and extracted useTransitionHeight from nav bar and put it into a @clayui/shared package. I went with the shared package because we need to publicly expose it as well as have versions for it. I'm not too concerned about the overhead in maintaining it since it is just another package similar to the others we are creating and should go through the same workflow. For now I think we isolate shared hooks there and avoid publicly promoting it as a package that other people should consume, this way we can keep from the overhead of adding features to this specific package.

[bryceosterhaus]

I decided to make this explicit to only "height" right now. In the future I can imagine this being expanded to all transitions, but wanted to narrow our scope now and not make it generic until we actually need it for other use cases.

[matuzalemsteles]

Yeah, makes sense. You did well.

[matuzalemsteles]

No problem Bryce, we can go with it that way. Thanks for this, I just left a comment to add warnings.

[matuzalemsteles]

hey @bryceosterhaus you can put some warnings that this package for a moment is only for internal use and that the API's are unstable and can be modified at any time and that "use at your own risk".

[bryceosterhaus]

Good call, I went ahead and updated the README.

[matuzalemsteles]

LGTM!