Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make globs work on Windows #2933

Merged
merged 1 commit into from
Feb 14, 2020
Merged

fix: make globs work on Windows #2933

merged 1 commit into from
Feb 14, 2020

Conversation

wincent
Copy link
Contributor

@wincent wincent commented Feb 14, 2020

Analogous change to this one on the alloy-editor repo:

liferay/alloy-editor#1374

Just in case anybody is ever foolhardy enough to try doing development on this repo on Windows.

Analogous change to this one on the alloy-editor repo:

liferay/alloy-editor#1374

Just in case anybody is ever foolhardy enough to try doing development
on this repo on Windows.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4374

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.226%

Totals Coverage Status
Change from base Build 4372: 0.0%
Covered Lines: 2149
Relevant Lines: 2553

💛 - Coveralls

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bfab7d6:

Sandbox Source
infallible-jones-djt0s Configuration
crazy-agnesi-s5f4p Configuration

Copy link
Member

@bryceosterhaus bryceosterhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants