fix(@clayui/css): Mixins clay-form-control-variant old keys should win over new keys
#4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…win over new keys issue liferay#3987
…ixin should use new keys. This allows variable theme overwrites using deprecated keys to still win. issue liferay#3987
8 tasks
|
LGTM! do we need something more to merge it? will we wait for the rest of #3987 tasks or this is not needed it? |
matuzalemsteles
added this to the LPS-130562 - Bi-weekly Clay release May 5th milestone
|
This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-130562 |
pat270
added a commit
to pat270/clay
that referenced
this pull request
May 13, 2021
…re Cadmin got merged: liferay#3998, liferay#4002, liferay#4040, liferay#4055, liferay#4056, liferay#4060 fixes liferay#4064
This was referenced May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the way we merge Sass map keys in
clay-form-control-variantso deprecated keys will win over the new ones. This is for backward compatibility with older versions of Clay CSS.issue #3987