Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@clayui/css): Links convert variables to use nested Sass map pattern #4148

Merged
merged 2 commits into from
Jun 28, 2021
Merged

fix(@clayui/css): Links convert variables to use nested Sass map pattern #4148

merged 2 commits into from
Jun 28, 2021

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Jun 23, 2021

fixes #4144

pat270 added 2 commits June 22, 2021 15:43
@pat270
fix(@clayui/css): Mixin Links don't use nested setters. The setter fu…
dfa1ea2 
…nction takes an Argslist now, we can pass any number of Sass maps with one function call
@pat270
fix(@clayui/css): Links convert variables to use nested Sass map pattern
1a9d654 
fix(@clayui/css): Cadmin Links convert variables to use nested Sass map pattern
matuzalemsteles
matuzalemsteles approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matuzalemsteles
Copy link
Member

Hey @pat270, this is in line with initiatives #3987, right?

@matuzalemsteles matuzalemsteles merged commit eca4b83 into liferay:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matuzalemsteles matuzalemsteles matuzalemsteles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@clayui/css Link convert Sass maps to use nested maps pattern
2 participants
@pat270 @matuzalemsteles