LPD-46157 Create Icon Selector (No Keyboard Interactions) #5929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilzamcmed
changed the title
|
Hey @matuzalemsteles, this is the inicial commits for the icon selector component. |
ilzamcmed
force-pushed
the
LPD-46157
branch
3 times, most recently
from
e830590 to
037661f
Compare
…display items on a grid, filter options and select an icon
…t and it's imports
ethib137
reviewed
Jan 31, 2025
Comment on lines
+124
to
+145
| const fetchIcons = () => { | ||
| const iconNames: Array<string> = []; | ||
|
|
||
| fetch(spritemap) | ||
| .then((res) => res.text()) | ||
| .then((res) => { | ||
| const parser = new DOMParser(); | ||
| const doc = parser.parseFromString(res, 'image/svg+xml'); | ||
|
|
||
| const symbols = doc.querySelectorAll('symbol'); | ||
|
|
||
| symbols.forEach((symbol) => | ||
| iconNames.push(symbol.getAttribute('id') || '') | ||
| ); | ||
|
|
||
| setIconNames(iconNames); | ||
| }); | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| fetchIcons(); | ||
| }, []); |
There was a problem hiding this comment.
We can use useResource here.
|
|
||
| import DropdownSelector from './DropdownSelector'; | ||
|
|
||
| export function IconSelector() { |
There was a problem hiding this comment.
Shouldn't we receive the same props from the DropdownSelector component here to pass to it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-46157
This pull request is a draft. As this is a new component, I will submit changes in stages to facilitate review.
Below there's a video of the component working.
I haven't worked on styles yet.
simplescreenrecorder-2025-01-27_17.05.24.mp4