Merge pull request #168 from liferay/wincent/export-no-source

fix(import-extensions): handle exports without sources
liferay · Apr 3, 2020 · df44835 · df44835
2 parents 2ff29ef + fb5ba95
commit df44835
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/plugins/eslint-plugin-liferay/lib/rules/import-extensions.js b/plugins/eslint-plugin-liferay/lib/rules/import-extensions.js
@@ -77,6 +77,7 @@ module.exports = {
 			} else if (
 				(node.type === 'ExportNamedDeclaration' ||
 					node.type === 'ExportAllDeclaration') &&
+				node.source &&
 				(node.source.type === 'Literal' ||
 					node.source.type === 'TemplateLiteral')
 			) {

diff --git a/plugins/eslint-plugin-liferay/tests/lib/rules/import-extensions.js b/plugins/eslint-plugin-liferay/tests/lib/rules/import-extensions.js
@@ -155,5 +155,17 @@ ruleTester.run('import-extensions', rule, {
 		{
 			code: `const billboard = not_a_require('billboard.js');`,
 		},
+		{
+			// Regression discovered here:
+			//
+			// https://github.com/liferay/liferay-npm-tools/pull/429#issuecomment-608451060
+			//
+			// Can't assume that all exports have a source.
+			code: `
+				const foo = 1;
+
+				export {foo};
+			`,
+		},
 	],
 });