This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
fix: make sort-import-destructures work with long lists #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old implementation happened to work with short lists but it made too many assumptions about the order in which pairs in the list would be compared. As soon as we tried running this on files with many names being destructured (like the one in the included regression test), then the assumption (that we'd only ever call element in list-order) was invalidated. V8 actually uses Timsort under the covers (https://v8.dev/blog/array-sort), but that is besides the point. We need to make sure the comparator function passed to `sort` behaves identically regardless of comparison order.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation happened to work with short lists but it made too many assumptions about the order in which pairs in the list would be compared. As soon as we tried running this on files with many names being destructured (like the one in the included regression test), then the assumption (that we'd only ever call element in list-order) was invalidated.
V8 actually uses Timsort under the covers (https://v8.dev/blog/array-sort), but that is besides the point. We need to make sure the comparator function passed to
sortbehaves identically regardless of comparison order.