This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
feat!: enforce use of strict (===) equality #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint can enforce this for us with the built-in "eqeqeq" rule, which you might not know about if you'd search for "strict", "equality" or "equal" in the rules list.
Idea is to avoid coercion due to
==
/!=
which can be a source of bugs, except in the case ofnull
, wherex == null
is a convenient and idiomatic shorthand forx === null || x === undefined
(you can still do an explicitx === null
check if that's what you want).Docs: https://eslint.org/docs/rules/eqeqeq
Closes: https://github.com/liferay/eslint-config-liferay/issues/158