This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
feat: add liferay-portal/no-explicit-extend rule #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to put this in the repo because it is an example of a
liferay-portal-specific lint that:
- Only applies to certain files.
- Includes an "autofix" functionality.
Test plan:
Run this in liferay-portal without:
brianchandotcom/liferay-portal#75813
See:
modules/apps/data-engine/data-engine-taglib/.eslintrc.js
16:12 error `liferay/portal` applies automatically and can be omitted liferay-portal/no-explicit-extend
modules/apps/dynamic-data-mapping/dynamic-data-mapping-form-builder/.eslintrc.js
16:12 error `liferay/portal` applies automatically and can be omitted liferay-portal/no-explicit-extend
modules/apps/dynamic-data-mapping/dynamic-data-mapping-form-web/.eslintrc.js
16:12 error `liferay/portal` applies automatically and can be omitted liferay-portal/no-explicit-extend
modules/apps/layout/layout-content-page-editor-web/.eslintrc.js
16:12 error `liferay/portal` applies automatically and can be omitted liferay-portal/no-explicit-extend
modules/apps/segments/segments-web/.eslintrc.js
16:12 error `liferay/portal` applies automatically and can be omitted liferay-portal/no-explicit-extend
✖ 5 problems (5 errors, 0 warnings)
5 errors and 0 warnings potentially fixable with the `--fix` option.
ESLint checked 562 files, found 5 errors, found 0 warnings, 5 issues potentially fixable with lint:fix
Which are the same files reported by `git grep 'extends:.+liferay'`:
apps/app-builder/app-builder-web/.eslintrc.js:16: extends: ['liferay/react']
apps/data-engine/data-engine-taglib/.eslintrc.js:16: extends: ['liferay/portal', 'liferay/metal']
apps/dynamic-data-mapping/dynamic-data-mapping-form-builder/.eslintrc.js:16: extends: ['liferay/portal', 'liferay/metal']
apps/dynamic-data-mapping/dynamic-data-mapping-form-web/.eslintrc.js:16: extends: ['liferay/portal', 'liferay/metal']
apps/layout/layout-content-page-editor-web/.eslintrc.js:16: extends: ['liferay/portal', 'liferay/react'],
apps/segments/segments-web/.eslintrc.js:16: extends: ['liferay/portal', 'liferay/react']
After running autofix, see this diff:
https://gist.github.com/wincent/6874c549f011937104266800ab724475
|
LGTM, @andresfulla, just FYI since we talked about this this morning. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to put this in the repo because it is an example of a liferay-portal-specific lint that:
Test plan:
Run this in liferay-portal without:
brianchandotcom/liferay-portal#75813
See:
Which are the same files reported by
git grep 'extends:.+liferay':After running autofix, see this diff:
https://gist.github.com/wincent/6874c549f011937104266800ab724475