This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
feat!: activate "no-console" rule #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested in liferay-portal: currently catches 1 issue, so I don't think this will be very noisy. Note that I tuned this to not complain about `console.warn` or `console.error`, which are generally used to report legitimate problems and are not expected to produce routine console spew (unlike `console.log`, which is often an overlooked piece of debug code that has been removed). Closes: #74
|
Ignoring the Semantic Pull Request bot on this one because: zeke/semantic-pull-requests#51 |
brianchandotcom
pushed a commit
to brianchandotcom/liferay-portal
that referenced
this pull request
Oct 30, 2019
As of liferay/eslint-config-liferay#79 we activated the "no-console" rule, allowing use of "console.warn" and "console.error" as exceptions. So, there are a few places in liferay-portal where we have unnecessary suppressions (because they relate to "warn" or "error" calls, or because they use "log" calls that really should be "warn"/"error"). Additionally, as per the guidelines at: https://github.com/liferay/liferay-frontend-guidelines/blob/c1f6e942ed19b8/dxp/debugging.md ...we try to minimize the use of logging outside of the development environment, so there is at least one place where a log call should be moved inside an appropriate guard check (the component already displays an empty state with an "error occurred and unable to load" message in theUI, so the logging is definitely redundant).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in liferay-portal: currently catches 1 issue, so I don't think this will be very noisy.
Note that I tuned this to not complain about
console.warnorconsole.error, which are generally used to report legitimate problems and are not expected to produce routine console spew (unlikeconsole.log, which is often an overlooked piece of debug code that has been removed).Needless to say, tools that actually need to print the console can trivially suppress this lint.
Closes: #74