feat(npm-scripts): improve strategy for generating types, only generate types for modules that have changes to ts files or if their dependencies have changes #1146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here the goal is to only generate types when ts files have been changed. This is particularly helpful when running
ant format-source-current-branch
The strategy is to diff against the liferay working branch (master). If there are any typescript files changed then we re-build types for that module and it's dependents.
Here is the new output:
No changes to any files
new
--force
option when we want to re-build all types. Will primarily only be used by FI teamChanges to a single module's ts files. This rebuilds the changed module and any dependent modules
ant format-source-current-branch
when only java files have changedant format-source-current-branch
when ts files have changed