fix(liferay-theme-task): Update regex to allow mulitple semicolons for @import #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortunatomaldonado
force-pushed
the
LPD-3102
branch
2 times, most recently
from
0137b01 to
edfa89d
Compare
fortunatomaldonado
force-pushed
the
LPD-3102
branch
from
edfa89d to
734aef8
Compare
bryceosterhaus
approved these changes
Mar 7, 2024
| new RegExp( | ||
| '^@' + | ||
| name + | ||
| ' *(?:url\\(([^)]+)\\)|([^;\\n]*))(?: *([^;\\n]*))?;' |
There was a problem hiding this comment.
I'm terrible at reviewing regex, but my semi-trustworthy friend seems to indicate that this should be fine
|
@fortunatomaldonado I released a new version, liferay-theme-tasks/v11.5.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-3102
When a theme contains the following, the regex stops at the first semicolon, causing issues in the _rtl.css files.
@import url("https://fonts.googleapis.com/css2?family=Manrope:wght@300;500;600;700;800&display=swap");I was able to resolve this by adjusting the regex so it allows multiple semicolons.
Let me know if there are any questions or comments about this.
Thank you!