Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

feat: Adds missing mocks for Liferay built-ins #417

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

diegonvs
Copy link

No description provided.

@diegonvs diegonvs changed the title Adds missing mocks for Liferay built-ins feat: Adds missing mocks for Liferay built-ins Mar 18, 2020
@wincent
Copy link
Contributor

wincent commented Mar 19, 2020

@diegonvs Can you please address the CI errors?

Are there accompanying changes that should go in to liferay-portal at the same time as we ship this? (ie. removing local mocks)

Did you test that all of the existing tests in liferay-portal still pass with this change in place? Easiest way to do that is probably to overwrite the changed files in modules/node_modules/liferay-npm-scripts and then run all tests; I use a script for this, which basically does:

git grep -l '"test": ".*liferay-npm-scripts test.*"' -- '*/package.json' package.json | \
  xargs -n 1 dirname | \
  xargs -n 1 -o bash -c 'cd ${!#} && yarn test $0 "${@:1:$#-1}"'

@diegonvs
Copy link
Author

I left an error on eslint 🤦‍♂

Fixing it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants