Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

chore: update JS toolkit dependencies from v2.19.1 to v2.19.2 #497

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

wincent
Copy link
Contributor

@wincent wincent commented Sep 17, 2020

Because we need this revert.

Done with:

cd packages/liferay-npm-bundler-preset-liferay-dev
yarn add \
  babel-preset-liferay-standard@2.19.2 \
  liferay-npm-bundler-loader-css-loader@2.19.2 \
  liferay-npm-bundler-plugin-{exclude-imports,inject-imports-dependencies,inject-peer-dependencies,namespace-packages,replace-browser-modules,resolve-linked-dependencies}@2.19.2
cd ../liferay-npm-scripts
yarn add \
  liferay-npm-bridge-generator@2.19.2 \
  liferay-npm-bundler@2.19.2

Note that we have some cross-project coupling going on here that lead to duplicates in the yarn.lock file (output trimmed for brevity):

$ yarn why liferay-npm-bundler-plugin-resolve-linked-dependencies
[1/4] 🤔  Why do we have the module "liferay-npm-bundler-plugin-resolve-linked-dependencies"...?
=> Found "liferay-npm-bundler-plugin-resolve-linked-dependencies@2.19.2"
   - Hoisted from "_project_#liferay-npm-bundler-preset-standard#liferay-npm-bundler-plugin-resolve-linked-dependencies"
   - Hoisted from "_project_#liferay-npm-bundler-preset-liferay-dev#liferay-npm-bundler-plugin-resolve-linked-dependencies"
=> Found "liferay-theme-tasks#liferay-npm-bundler-plugin-resolve-linked-dependencies@2.19.1"
   - Hoisted from "_project_#liferay-npm-scripts#liferay-theme-tasks#liferay-npm-build-tools-common#liferay-npm-bundler-preset-standard#liferay-npm-bundler-plugin-resolve-linked-dependencies"

Neither yarn nor a yarn install --force were enough to get rid of it; had to go with rm yarn.lock && yarn. This gets rid of the duplicate dependencies from the liferay-js-toolkit project, but there are a bunch of others in here still, hopefully benign (eg. look at the @storybook dupes in there).

Because we need this revert:

liferay/liferay-js-toolkit#645

Done with:

    cd packages/liferay-npm-bundler-preset-liferay-dev
    yarn add \
      babel-preset-liferay-standard@2.19.2 \
      liferay-npm-bundler-loader-css-loader@2.19.2 \
      liferay-npm-bundler-plugin-{exclude-imports,inject-imports-dependencies,inject-peer-dependencies,namespace-packages,replace-browser-modules,resolve-linked-dependencies}@2.19.2
    cd ../liferay-npm-scripts
    yarn add \
      liferay-npm-bridge-generator@2.19.2 \
      liferay-npm-bundler@2.19.2

Note that we have some cross-project coupling going on here that lead to
duplicates in the yarn.lock file:

```
$ yarn why liferay-npm-bundler-plugin-resolve-linked-dependencies                                                                                 7.97s [wincent/deps] ~/code/liferay-npm-tools
[1/4] 🤔  Why do we have the module "liferay-npm-bundler-plugin-resolve-linked-dependencies"...?
=> Found "liferay-npm-bundler-plugin-resolve-linked-dependencies@2.19.2"
   - Hoisted from "_project_#liferay-npm-bundler-preset-standard#liferay-npm-bundler-plugin-resolve-linked-dependencies"
   - Hoisted from "_project_#liferay-npm-bundler-preset-liferay-dev#liferay-npm-bundler-plugin-resolve-linked-dependencies"
=> Found "liferay-theme-tasks#liferay-npm-bundler-plugin-resolve-linked-dependencies@2.19.1"
   - Hoisted from "_project_#liferay-npm-scripts#liferay-theme-tasks#liferay-npm-build-tools-common#liferay-npm-bundler-preset-standard#liferay-npm-bundler-plugin-resolve-linked-dependencies"
```

Neither `yarn` nor a `yarn install --force` were enough to get rid of
it; had to go with `rm yarn.lock && yarn`. This gets rid of the
duplicate dependencies from the liferay-js-toolkit project, but there
are a bunch of others in here still, hopefully benign (eg. look at the
`@storybook` dupes in there).
@wincent
Copy link
Contributor Author

wincent commented Sep 17, 2020

CI is green and this is a routine update, so going to merge.

I don't like the size of the yarn.lock diff, but that won't have downstream effects in the dependency graph of liferay-portal, which is the only thing I care about here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant