LAFuture.collect crashes when futures are resolved out of order #1453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using LAFuture.collect from Lift 3 Snapshot to collect 3 futures into one. It sometimes throws an IndexOutOfBoundsException at me.
The reason is this line:
val vals = new collection.mutable.ArrayBufferBox[T]
which defines the result array. Later, when future 2 is satisfied before future 1 it tries to insert it at a index that does not yet exist, thus throwing the exception.
The fix I found was to pad the array with Empty's and then later in the foreach write a Full into it.
Here's the repl that produces the exception:
scala> new collection.mutable.ArrayBufferInt
res0: scala.collection.mutable.ArrayBuffer[Int] = ArrayBuffer()
scala> res0.insert(2, 4)
java.lang.IndexOutOfBoundsException: 2