Memoize declared fields to avoid reflection during case class decomposition #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't had a chance to take this for a spin yet, but it looks good. |
|
👍 |
|
Gonna give this guy a test right quick like. |
|
Change looks simple enough; specs are passing in 2.9.1-2.10... let's get this guy in. |
farmdawgnation
added a commit
that referenced
this pull request
Feb 15, 2014
Memoize declared fields to avoid reflection during case class decomposition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the memoize pattern in Meta to cache class fields avoiding reflection on subsequent calls.
The change discussion on the mailing list:
https://groups.google.com/forum/#!topic/liftweb/O9DDgSZqkkc
Contributor file signature:
https://github.com/lift/framework/blob/master/contributors.md#name-23