Make HLists covariant in their type parameters. #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a spec for HList length.
| @@ -116,7 +96,7 @@ object HLists { | |||
| * Carries the information about the type of this element, plus the `HList` | |||
| * type of the rest of the list. | |||
| * | |||
| * You can use `:+:` to make this `HList` longer: | |||
| * You can use `[[HListMethods.:+: :+:]]` to make this `HList` longer: | |||
| * | |||
| * {{{ | |||
There was a problem hiding this comment.
would you want to update the scaladoc style while you are here or are you planning on doing another massive pass at docs on a separate PR?
There was a problem hiding this comment.
I actually waited until the other docs PR for lift-common went in, so these docs should all be up-to-date, I think. Did you see an issue? I kind of had to move the tweaks I'd made for lift-formality into the already-properly-doced file, so it's possible I missed something.
|
👍 |
|
I'm not sure how much HLists are being used in general, but given one thumbs up I'll probably merge this tomorrow unless someone else protests vehemently :p |
|
I'm not sure when “tomorrow” turned into “in 6 days”, but in we go :p |
Shadowfiend
added a commit
that referenced
this pull request
Jan 14, 2015
Make HLists covariant in their type parameters. Also add a spec for HList length. I'm using this code in lift-formality and it works as advertised!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a spec for HList length.
I'm using this code in lift-formality and it works as advertised, but it's nicer if
I don't keep my own copy of it ;)