Fixes LAFuture.collect/collectAll behaviour for empty list parameter #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For empty list parameter, were returned future which never been satisfied. Now is returned future that is immediately satisfied by empty list.
Closed
|
Please remember to add your name to the contributors.md file. |
|
Done it. Thank you for reminder. |
|
Winner! Dig this one, I'm 👍 . Will give it a day to see if any concerns are brought up by other committers and then merge 'er. |
|
Looks great! 👍 |
|
Alllll righty let's put 'er in! |
Shadowfiend
added a commit
that referenced
this pull request
Jan 8, 2015
Fixes LAFuture.collect/collectAll behaviour for empty list parameter For empty list parameter, were returned future which never been satisfied. Now is returned future that is immediately satisfied by empty list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For empty list parameter, were returned future which never been satisfied.
Now is returned future that is immediately satisfied by empty list.
Fixes #1653