RC Fixes #1779
RC Fixes #1779
Conversation
The WebSpec extension classes like SessionSpecification were creating fragments, but weren't adding them to the fragments to run, so those tests were never getting executed. We now properly add the generated fragments to the list of fragments to run.
Due to how we'd structured provider loading, we eagerly looked up props when the Props singleton was first instantiated. This prevented the customization point that is updating `whereToLook` from working. We now indirect providers access a bit so as to lazy-load providers when we first access a property, and then we can respect whereToLook and look things up as the user wants them. Also added a test verifying this behavior.
In particular, things that need to be set before Props are accessed.
It wasn't locking the run mode, so it wasn't really testing what it wanted to be testing.
We were looking up system properties with the same name in two tests, which led to potential concurrency issues running those tests in parallel.
|
@karma4u101 if you can confirm this fixes the issue you found with |
|
@Shadowfiend LGTM I tested against my module and this PR fixes the issue. I also took a look at the lift-webkit tests and they all (related to WebSec usage) run with executed examples without errors. I did however unrelated to this PR notice "java.lang.IllegalStateException: Cannot modify after boot" issues in the end of running the lift-webkit tests. |
|
@karma4u101: no worries about that exception AFAIK. I've seen it on my last few PRs and it seems harmless. |
|
I think these are in-process jetty boots that are done during tests, but I think they have the same boot setup. Since they're in the same process, two boots blows up, but because the boot setup is the same things still run smoothly. |
RC Fixes Couple of fixes so we can get the RC out the door: - Fix WebSpec's broken fragments. - Props respects whereToLook again and now has a test verifying that this works as expected. Also some small deprecation, spec, and scaladoc-related fixes.
Couple of fixes so we can get the RC out the door:
whereToLookagain (see Props.whereToLook does not work in 3.0-M8 #1776) and now has a testverifying that this works as expected.
Also some small deprecation, spec, and scaladoc-related fixes.