Add special handling for UnavailableException #1861
Conversation
This code adds special handling for javax.servelet.UnavailableException. This exception is an idiomatic way to signal a full abort to the Java Application server running the application. Please see #1843 for more information.
|
@fanf This PR resolves the issue you logged regarding |
| logger.error("------------------------------------------------------------------") | ||
| logger.error("------------------------------------------------------------------") | ||
| logger.error("------------------------------------------------------------------") | ||
| logger.error("********** Failed to Boot! An unavailable exception was thrown an all futher boot activities are aborted", unavailableException); |
There was a problem hiding this comment.
I might say “An UnavailableException was thrown”; either way, it should be “and” rather than “an”.
| logger.error("------------------------------------------------------------------") | ||
| logger.error("------------------------------------------------------------------") | ||
| logger.error("------------------------------------------------------------------") | ||
| logger.error("------------------------------------------------------------------") |
There was a problem hiding this comment.
Do we really need the four lines of dashes? Feels like one should be more than enough……
There was a problem hiding this comment.
I'm not super opinionated on this, personally, but I'm inclined to leave it as is for now and reconsider when we next touch this code.
|
This is ok with me, the behavior is what is needed. I'm not fan of the big error message, but I understand the need for consistancy. |
|
Yeah, I think we'll revisit that error message at some point in the future. |
|
Cool, then I think this is good to merge. |
|
Let us, as they say in the lands of Sekulampa, do it. |
Mailing List thread:
https://groups.google.com/forum/#!topic/liftweb/BHYjE5C-kIk
This code adds special handling for javax.servelet.UnavailableException.
This exception is an idiomatic way to signal a full abort to the Java
Application server running the application.
From now on, we will log and re-throw this exception if we see it.
Fixes #1843