Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#1919: Asset root path should be configurable #1933

Merged
merged 3 commits into from
Mar 7, 2018

Commits on Jan 16, 2018

  1. Issue#1919: Asset root path should be configurable

    Added 'assetPath' variable to LiftRules, with default value '/assets'. Rest of the path structure is still convention based, not configurable.
    
    This will address the issue where the Lift template projects are storing the lazy loading gif under assets folder and the framework library expects it to reside at the root level.
    
    On the other hand, also if the default place for the assets is in the way of the application for a reason or another, it is now easier to move somewhere else.
    
    Added also my name to the contributors.md file, as instructed in the documentation.
    heharkon committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    f28f01f View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2018

  1. Updated the default asset path to be "/" to avoid breaking old apps. …

    …Also the path must now end with "/" to denote a directory, rather that leave it open as it was before.
    heharkon committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    a3ab6c5 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Changed the variable name. Also updated the scaladoc to be more preci…

    …se about where this variable effects.
    heharkon committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    3d1435d View commit details
    Browse the repository at this point in the history