Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snapshot builds #1968

Merged
merged 2 commits into from
Jul 21, 2019
Merged

Fix snapshot builds #1968

merged 2 commits into from
Jul 21, 2019

Conversation

farmdawgnation
Copy link
Member

This PR should fix our snapshot building on master. It will:

  • Fix doc generation by fixing up our api mappings override for scala-xml
  • Disable publishing from jdk11 and jdk12 so we don't cause surprises

closes #1964

Shadowfiend
Shadowfiend approved these changes Jul 21, 2019
View reviewed changes
Copy link
Member

@Shadowfiend Shadowfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooooks good to me 😎

@Shadowfiend Shadowfiend merged commit 12349d9 into master Jul 21, 2019
@Shadowfiend Shadowfiend deleted the fix-snapshot-builds branch July 21, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadowfiend Shadowfiend Shadowfiend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Lift 3.4.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNAPSHOT publishing is broken
2 participants
@farmdawgnation @Shadowfiend