Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly call __remill_undef for undefined arith flags. #543

Merged
merged 5 commits into from
Sep 27, 2021
Merged

Explicitly call __remill_undef for undefined arith flags. #543

merged 5 commits into from
Sep 27, 2021

Conversation

lkorenc
Copy link
Contributor

@lkorenc lkorenc commented Sep 21, 2021

Implements part of #541

@lkorenc lkorenc added the x86 Related to x86/x86-64/AMD64 lifting support label Sep 21, 2021
@lkorenc lkorenc requested a review from pgoodman September 21, 2021 14:43
@lkorenc lkorenc self-assigned this Sep 21, 2021
@lkorenc
Copy link
Contributor Author

lkorenc commented Sep 27, 2021

@pgoodman Should be good to go. Failing test case is instruction (cpuid) this PR does not touch so I am not sure why that happened.

@pgoodman pgoodman merged commit 14a58af into master Sep 27, 2021
@pgoodman pgoodman deleted the undefined_aflags branch September 27, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgoodman pgoodman pgoodman approved these changes

Assignees

@lkorenc lkorenc

Labels
x86 Related to x86/x86-64/AMD64 lifting support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkorenc @pgoodman