Trap interrupt during option input #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
| @config.company = ask('Company name? ') { |q| q.default = @config.company } | ||
| @config.author = ask('Author name? ') { |q| q.default = @config.author } | ||
| @config.prefix = ask('Prefix? ') { |q| q.default = @config.prefix }.upcase | ||
| begin |
There was a problem hiding this comment.
Since the whole method is in the begin, you don't need it:
def foo
bar
baz
rescue SpecificErrorClass
bat
end
There was a problem hiding this comment.
Of course, using begin is also fine. We emphatically do not have a style guide for this ;)
|
Yup. No better way I can think of to capture interrupts. |
| @config.author = ask('Author name? ') { |q| q.default = @config.author } | ||
| @config.prefix = ask('Prefix? ') { |q| q.default = @config.prefix }.upcase | ||
| rescue Interrupt, EOFError | ||
| exit 1 |
There was a problem hiding this comment.
This should be exit 0 for EOFError - that is, I think EOFError is ctrld, and I know that ctrld should be a 0 (successful) exit.
|
Great refactoring. |
* Extract OptionFetcher This class handles fetching the options from the user, and manages the various interrupt signals during input Fixes #81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81