Add company_identifier property to configuration #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| end | ||
|
|
||
| context 'when the identifier is not set directly' do | ||
| it 'returns a reverse domain string from the normalized company name if not set' do |
There was a problem hiding this comment.
I think if not set duplicates the context information.
There was a problem hiding this comment.
Oops, I meant to remove that when I added the context
This allows users to provide (or pre-define using the liftoffrc) a company identifier to use for the project. By default, we will construct a company identifier for the user by normalizing the provided company name and prepending 'com.'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to provide (or pre-define using the liftoffrc) a company
identifier to use for the project. By default, we will construct a company
identifier for the user by normalizing the provided company name and
prepending 'com.'
Fixes #94