Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple small improvements #133

Merged
merged 2 commits into from
Mar 21, 2014
Merged

Couple small improvements #133

merged 2 commits into from
Mar 21, 2014

Conversation

gfontenot
Copy link
Member

No description provided.

houndci-bot
houndci-bot reviewed Mar 20, 2014
View reviewed changes
lib/liftoff/deprecation_manager.rb
module Liftoff
class DeprecationManager
DEPRECATIONS = {
:install_todo_script => 'run_script_phases',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

@gfontenot
Copy link
Member Author

@gabebw Is this good to merge?

@gabebw
Copy link
Contributor

gabebw commented Mar 21, 2014

👍

@gfontenot
Add deprecation manager
42d7f8d 
This class will handle the mappings between deprecated keys and their
replacements.
@gfontenot
Break configuration attributes into multiple lines
021d160
@gfontenot gfontenot merged commit 021d160 into master Mar 21, 2014
@gfontenot gfontenot deleted the gf-deprecations branch March 21, 2014 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gfontenot @gabebw @houndci-bot