Add pods to default podspec for network stubbing #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Any thoughts from the rest of @thoughtbot/ios? |
|
👍 |
|
I actually ran into a nasty race condition related to stubs being removed before getting called when clearing them after each test, so until I've got a better solution for that, I'm going to remove the |
- OHHTTPStubs is a fantastic library for quickly and easily stubbing network requests - XCTest+OHHTTPStubSuiteCleanUp ensures that all stubs are reset after each test. This ensures that tests aren't dependent on interacting with each other. Just including this pod enables this feature. There is no need to import the pod anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network requests
each test. This ensures that tests aren't dependent on interacting
with each other. Just including this pod enables this feature. There
is no need to import the pod anywhere.