Force encoding to UTF-8 when normalizing comp name #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 |
|
Add a test? |
|
@gabebw oh yeah right tests. brb. |
gfontenot
force-pushed
the
gf-fix-utf8
branch
4 times, most recently
from
c6f5c75
to
2ecf886
Compare
|
@gabebw test added. Mind taking another gander? |
| @@ -83,7 +83,7 @@ def test_target_groups | |||
| private | |||
|
|
|||
| def normalized_company_name | |||
| company.gsub(/[^0-9a-z]/i, '').downcase | |||
| company.force_encoding('utf-8').gsub(/[^0-9a-z]/i, '').downcase | |||
There was a problem hiding this comment.
This is a nitpick, but what if we capitalize UTF-8? I almost never see it written lowercase, and if Ruby doesn't care I'd prefer uppercase.
gfontenot
force-pushed
the
gf-fix-utf8
branch
2 times, most recently
from
da158d6
to
409a832
Compare
|
The tests pass on my machine as well, even with |
|
How about changing the commit message: "Force UTF-8 when normalizing company name"? "comp name" reads oddly to me. |
This fixes a crash on non `en_US.UTF-8` systems, or when `LANG` isn't set properly.
gfontenot
force-pushed
the
gf-fix-utf8
branch
from
409a832
to
e90a857
Compare
|
Done. Thanks, @gabebw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash on non
en_US.UTF-8systemsFixes #171