Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override the deployment target #199

Closed
wants to merge 1 commit into from
Closed

Allow to override the deployment target #199

wants to merge 1 commit into from

Conversation

bitcrumb
Copy link
Contributor

The deployment target can now be set by specifying it in the liftoffrc file, it will override the default of LATEST_IOS

The deployment target can now be set by specifying it in the liftoffrc file, it will override the default of LATEST_IOS
@gfontenot
Copy link
Member

Nice! Feel like getting your hands dirty and learning mdoc? If we're letting this be specified in the liftoffrc, we should add it to the documentation in liftoffrc(5).

@bitcrumb
Copy link
Contributor Author

bitcrumb commented Dec 5, 2014

Sure, good point. I'll have a look at it! Reminds me that I should do the same for the --[no-]settings cli option added in #191.

@gfontenot
Copy link
Member

Ah, yeah, that should be added to liftoff(1). That one should be easier. I'll merge this if you want to open a new PR with the documentation changes?

@bitcrumb
Copy link
Contributor Author

bitcrumb commented Dec 5, 2014

Go ahead, will do.

@gfontenot
Copy link
Member

Merged in 802956a

@gfontenot gfontenot closed this Dec 5, 2014
@bitcrumb
Copy link
Contributor Author

bitcrumb commented Dec 5, 2014

Done, see #202.

@bitcrumb bitcrumb deleted the feature/custom-deployment-target branch December 5, 2014 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants