Adding support to creating custom build_configurations

[marcelofabri]

This enables creation of custom build configurations by adding build_configurations to .liftoffrc:

build_configurations:
    - name: Debug-CI
      type: debug
    - name: Release-CI
      type: release

type must be release or debug (or else it'll error in add_build_configuration). As xcodeproj itself doesn't explicitly checks for these, I followed the same rule. I also haven't checked if both name and type were specified as I haven't seen this pattern through the codebase.

create_build_configurations was called before configure_base_project_settings so all further configuration is also applied to the created configurations.

The created build configurations should be accessible from extra_config, but I haven't tested it yet.

UPDATE: I have tested using extra_config and it did work as expected.

Also, I haven't updated the documentation yet and haven't created tests for this (some help here would be greatly appreciated).

[bitcrumb]

Good stuff 👍🏻

[solrankos]

This would help me so much! 👍 🔝

[jakecraige]

What do you think about providing a method on the BuildConfigurationBuilder that accepts an array of build configurations and adds them to the project? Pretty much copy and pasting this section into there

[marcelofabri]

This was my first thought, but then I thought that it'd be better if BuildConfigurationBuilder didn't have to deal with any hashes (to avoid an informal contract about the keys). Does that make sense?

[jakecraige]

That makes sense. I don't feel super strong either way. To play devil's advocate:

Could we safely assume that the generate_build_configurations method accepts an array of hashes with a name and type and in this case they happen to match? If they keys ever change we could update this section to pass in that structure and not have to change the class.

[marcelofabri]

OK, I've added a generate_build_configurations method.

[jakecraige]

Looks great! Is this still a WIP? Feel free to squash down when it's ready

[marcelofabri]

Yeah, I still need to add some documentation than we're ready!

[jakecraige]

Good catch :) Feel free to ping me when you're ready and I'll take a look.

[marcelofabri]

@jakecraige Done!

[jakecraige]

Good stuff. Merged in ce47d4b

[marcelofabri]

🎉