Add Bundler dependency manager #260
Conversation
| @@ -35,7 +35,7 @@ def global_options | |||
| @options[:strict_prompts] = strict_prompts | |||
| end | |||
|
|
|||
| opts.on('--dependency-managers [NAME(s)]', 'Comma separated list of dependency managers to enable. Available options: cocoapods,carthage') do |list| | |||
| opts.on('--dependency-managers [NAME(s)]', 'Comma separated list of dependency managers to enable. Available options: cocoapods,carthage,bundler') do |list| | |||
There was a problem hiding this comment.
Line is too long. [164/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
There was a problem hiding this comment.
I just turned this on, and it runs counter to existing style, but we should follow it (and make note of places that the style needs to be updated)
|
This is rad. I'm happy it dropped into the existing architecture so well. |
|
Let me rebase and squash all these commits if you decide to merge. |
| <% if enable_settings && dependency_manager_enabled?("cocoapods") %> | ||
| pod install | ||
| <% end %> | ||
| <% if dependency_manager_enabled?("carthage") %> | ||
| carthage update | ||
| <% end %> | ||
| <% if dependency_manager_enabled?("bundler") %> | ||
| bundle install |
There was a problem hiding this comment.
Probably it makes sense to do it first, so CocoaPods can be installed via bundler?
|
@jakecraige Mind giving this a gander, since you implemented the other dependency managers? |
|
Sorry for the delay at looking this over. I'll try to get to it by the end of the week. |
Bundler was already around in the codebase with a Gemfile, but now it can explicitly included or excluded (default excluded). It copies the Gemfile and runs `bundle install`. It is enabled with the command line flag `--dependency-managers bundler` or in .liftoffrc: `dependency_managers: bundler` Bundler comes first in the setup script because cocoapods can be installed via bundler. Support bundler through the rest of the codebase Shorten options line length Format liftoffrc manpage Reorder bundler in script Bundler is used to install cocoapods so it should come first
edwardloveall
force-pushed
the
el-bundler
branch
from
493d19c
to
dc9d508
Compare
|
Thanks! Merged as 8439456 |
This adds bundler as a dependency manager. It seems to work (copies files, runs
bundle install) but because I'm not deeply familiar with Xcode I wouldn't be surprised if there was something obvious missing. I'd love to see someone who knows better than I do actually run this and see if it does what they would expect.cc @keith because you requested it initially
Resolves #156