Avoid SIGABORT with Xcode 9 #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcodeproj-1.1.0 was using a private framework from within Xcode.app bundle to generate the xcodeproj (using ffi to call Apple's private C/ObjC library). That private framework was updated in Xcode 9 and its API has changed, leading to a SIGABORT during the ffi call if Xcode 9 was xcode-select'd. More recent versions of xcodeproj fixed that problem by not relying on that private framework anymore, using the nanaimo gem instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xcodeproj-1.1.0 was using a private framework from within Xcode.app bundle to generate the xcodeproj (using ffi to call Apple's private C/ObjC library).
That private framework was updated in Xcode 9 and its API has changed, leading to a
SIGABORTduring the ffi call if Xcode 9 was xcode-select'd.More recent versions of xcodeproj fixed that problem by not relying on that private framework anymore, using the
nanaimogem insteadThis fix is important to keep liftoff working with Xcode 9, but the fix is very simple, as it just consists of bumping dependencies using
bundle update, so no new tests have been needed (existing ones still pass) and no new feature have been introduced.